Restructure app init; fixes #5 and #11

Squashed commit of the following:

commit d4242bf1a390994606b7bd6e630c55338a14aad4
Author: Arne Schlüter <arne@schlueter.is>
Date:   Mon Jul 9 21:12:44 2018 +0200

    Add loading spinner, done with reworked app boot flow; fixes #5 and #11

commit e864ae4e578f96b86f3c0239b79f5224f0bb0020
Author: Arne Schlüter <arne@schlueter.is>
Date:   Mon Jul 9 19:43:02 2018 +0200

    Start restructuring app boot flow

commit a8cdbef80acde9f185a588ab86f8ea6964ebe8ab
Author: Arne Schlüter <arne@schlueter.is>
Date:   Mon Jul 9 14:03:43 2018 +0200

    Ignore rebel readline artifacts

commit 67eae3bc6aa2938ad6748c78b6259e532e66f865
Author: Arne Schlüter <arne@schlueter.is>
Date:   Mon Jul 9 14:03:11 2018 +0200

    Update shadow-cljs and run npm audit fix

test/cljs/airsonic_ui/events_test.cljs

@@ -8,50 +8,64 @@
 
 (enable-console-print!)
 
+(into [] (conj [[:foo :bar :baz]] nil))
+
+(defn dispatches?
+  "Helper to see whether an event is dispatched in a coeffect; `ev` can either
+  be a whole vector or a keyword which is interpreted as the event name."
+  [cofx ev]
+  (let [all-events (conj (or (:dispatch-n cofx) []) (:dispatch cofx))]
+    (some #(if (vector? ev)
+             (= ev %)
+             (= ev (first %)))
+          all-events)))
+
+(deftest session-restoration
+  (letfn [(no-previous-session []
+            (events/restore-previous-session {} [:_]))
+          (has-previous-session []
+            (events/restore-previous-session {:store {:u "test"
+                                                      :p "test"
+                                                      :server "https://demo.airsonic.io/"}} [:_]))]
+    (testing "Should initialize routing after checking for previous credentials"
+      (is (contains? (no-previous-session) :routes/start-routing))
+      (is (contains? (has-previous-session) :routes/start-routing)))
+    (testing "Should indicate success or failure"
+      (is (dispatches? (no-previous-session)) :init-flow/credentials-missing)
+      (is (dispatches? (has-previous-session)) :init-flow/credentials-found))
+    (testing "Should send an auth request on success"
+      (is (dispatches? (events/credentials-found {} [:_]) :credentials/verification-request)))
+    (testing "Should redirect to the login form when there's no previous session to be restored")))
+
 (deftest authentication
-  (testing "Credential verification"
+  (testing "Server ping for verifications"
     (let [server "https://localhost"
-          fx (events/authenticate {:db {}} [:_ "user" "pass" server])
+          fx (events/credentials-verification-request {} [:_ "user" "pass" server])
           request (:http-xhrio fx)]
       (testing "uses correct server url"
         (is (str/starts-with? (:uri request) server))
-        (is (str/includes? (:uri request) "/ping")))
-      (testing "saves the given server location"
-        (is (= server (get-in fx [:db :credentials :server]))))
+        (is (str/includes? (:uri request) "/ping"))
+        (is (str/includes? (:uri request) "p=pass"))
+        (is (str/includes? (:uri request) "u=user")))
       (testing "invokes correct success callback"
-        (is (= ::events/verify-auth-response (first (:on-success request)))))))
+        (is (= :credentials/verification-response (first (:on-success request)))))))
   (testing "Auth response verification"
-    (is (= :notification/show
-           (first (:dispatch (events/verify-auth-response {} [:_ "user" "pass" (:error responses)]))))
-        "shows an error when we have an error response")
-    (let [event (:dispatch (events/verify-auth-response {} [:_ "username" "password" (:auth-success responses)]))]
-      (is (= [::events/credentials-verified "username" "password"] event))))
+    (let [server "https://localhost"
+          fx (events/credentials-verification-response {} [:_ "user" "pass" server (:error responses)])]
+      (is (= (dispatches? fx :notification/show))
+          "shows an error when we have a bad response"))
+    (let [server "https://localhost"
+          fx (events/credentials-verification-response {} [:_ "username" "password" server (:auth-success responses)])]
+      (is (dispatches? fx [:credentials/verified "username" "password" server]))))
   (testing "On succesful response"
-    (let [creds-before {:server "https://localhost"}
-          fx (events/credentials-verified {:db {:credentials creds-before}}
-                                          [:_ "user" "pass"])
-          auth {:u "user" :p "pass"}]
-      (testing "credentials are sent to the router for access rights"
-        (is (= auth (:routes/set-credentials fx))))
-      (testing "credentials are saved in the global state"
-        (is (= auth (-> (get-in fx [:db :credentials])
-                               (select-keys [:u :p])))))
-      (testing "credentials are persisted together with the server address"
-        (is (= (merge creds-before auth) (get-in fx [:store :credentials]))))
-      (testing "the login process is finalized"
-        (is (= [::events/logged-in] (:dispatch fx))))))
-  (testing "When remembering previous login data"
-    (let [credentials {:server "http://localhost"
-                       :u "another-user"
-                       :p "some_random_password123"}
-          fx (events/try-remember-user {:store {:credentials credentials}} [:_])]
-      (testing "the auth request is skipped"
-        (is (nil? (:http-xhrio fx))))
-      (testing "we get sent straight to the home page"
-        (is (= ::events/credentials-verified (first (:dispatch fx)))))))
-  (testing "When there's no previous login data"
-    (testing "remembering has no effect"
-      (is (nil? (events/try-remember-user {} [:_]))))))
+    (let [credentials {:u "user" :p "pass" :server "https://localhost"}
+          fx (events/credentials-verified {} [:_ (:u credentials) (:p credentials) (:server credentials)])]
+    (testing "credentials are sent to the router for access rights"
+      (is (= credentials (:routes/set-credentials fx))))
+    (testing "credentials are saved in the global state"
+      (is (= credentials (get-in fx [:db :credentials]))))
+    (testing "the login process is finalized"
+      (is (dispatches? fx ::events/logged-in))))))
 
 (deftest logout
   (let [fx (events/logout {} [:_])]
@@ -62,7 +76,11 @@
     (testing "Should unset authentication in the router"
       (is (contains? fx :routes/unset-credentials)))
     (testing "Should reset the app-db"
-      (is (= db/default-db (:db fx))))))
+      (is (= db/default-db (:db fx)))))
+  (testing "Should be able to keep a redirection parameter"
+    (let [redirect [:route {:with-data #{1 2 3 4 5}}]
+          fx (events/logout {} [:_ :redirect-to redirect])]
+      (is (= [::routes/login {:redirect redirect}])))))
 
 (defn- first-notification [fx]
   (-> (get-in fx [:db :notifications]) vals first))

test/cljs/airsonic_ui/routes_test.cljs

@@ -0,0 +1,14 @@
+(ns airsonic-ui.routes-test
+  (:require [airsonic-ui.routes :as routes]
+            [cljs.test :refer [deftest testing is]]))
+
+(def fixtures
+  {:default [::route {:some :data} {:some-more true}]})
+
+(deftest route-encoding
+  (testing "Should return a string with hash-compatible characters"
+    (let [encoded (routes/encode-route (:default fixtures))]
+      (is (string? encoded))
+      (is (re-matches #"^[^#?&=]+$" encoded))))
+  (testing "Should be bijective"
+    (is (= (:default fixtures) (routes/decode-route (routes/encode-route (:default fixtures)))))))